feat: agent get SPD syncly #558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
- Coverage 56.06% 55.90% -0.17%
==========================================
Files 534 534
Lines 49807 49828 +21
==========================================
- Hits 27924 27856 -68
- Misses 18325 18420 +95
+ Partials 3558 3552 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddjjia
force-pushed
the
feat/spdfetcher-updateSPDCache-from-latest
branch
from
eb05ece
to
a2ba65b
Compare
ddjjia
force-pushed
the
feat/spdfetcher-updateSPDCache-from-latest
branch
from
90f3a7e
to
0ce43ec
Compare
luomingmeng
reviewed
Jun 25, 2024
| @@ -159,6 +161,28 @@ func (s *spdFetcher) getSPDByNamespaceName(_ context.Context, namespace, name st | |||
| currentSPD := s.spdCache.GetSPD(key, true) | |||
| if currentSPD != nil { | |||
| return currentSPD, nil | |||
| } else if s.getFromRemote { | |||
| klog.Infof("[spd-manager] need to get spd %s from remote", key) | |||
There was a problem hiding this comment.
this logic in the getSPDByNamespaceName can be abstracted into a function with the logic in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
get spd from remote if not in cache when GetFromRemote is true
Which issue(s) this PR fixes:
Special notes for your reviewer: